Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(makerdeb): Add name option and fix bin name #3726

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

coredev-uk
Copy link

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Basically as the title says, this implements a rename function to correct the file name of the .deb output to the user specified value. This also corrects the bin name to enforce the use of the executableName. In situations where the app name in the package.json does not match the executableName in the packagerConfig it errors due to package generating an executable following the executableName value which is not what MakerDeb is expecting.

fix: Apply the executable name correctly over using package name
@coredev-uk coredev-uk requested a review from a team as a code owner October 2, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant